Fix incorrect nesting of liveness and readiness probes#118
Merged
MarshallAsch merged 3 commits intoplexinc:masterfrom Dec 31, 2024
Merged
Fix incorrect nesting of liveness and readiness probes#118MarshallAsch merged 3 commits intoplexinc:masterfrom
MarshallAsch merged 3 commits intoplexinc:masterfrom
Conversation
MarshallAsch
approved these changes
Dec 31, 2024
cookandy
approved these changes
Dec 31, 2024
Contributor
Author
|
I believe the checks are failing due to the fact that the liveness and readiness probes are by default empty which is not valid. I think this error didn't materialize itself in the previous PR due to it being hidden by the |
MarshallAsch
approved these changes
Dec 31, 2024
Contributor
Author
|
@MarshallAsch I think your commit is unsigned. Do you want me to redo the chart bump change and sign it myself? |
Member
|
no thats okay. I havent fixed my signing key so my commits are all unsigned now (I can bypass that requirement) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Liveness and readiness probes introduced in #117 are incorrectly nested within the
resourcestemplate. Adding resource limits to the pms chart results in the following error:This change fixes that issue.