Add ab_spam__invalid_request logic back to precheck() function#656
Open
2ndkauboy wants to merge 1 commit intofix/fixes-from-v2-comparisonfrom
Open
Add ab_spam__invalid_request logic back to precheck() function#6562ndkauboy wants to merge 1 commit intofix/fixes-from-v2-comparisonfrom
ab_spam__invalid_request logic back to precheck() function#6562ndkauboy wants to merge 1 commit intofix/fixes-from-v2-comparisonfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stklcode thanks for your comment on #655 about a failing test. After fixing the implementation of the Honypot precheck, I've restored the logic from
v2. In my opinion, the initial implementation of this rule inv3added an additional validation step, which might change how spam is detected. I believe it's a good addition, but I'm not sure it we should include it without further testing.This PR restored that new logic and also adds back the test that was failing in #655, which now works again.