-
Notifications
You must be signed in to change notification settings - Fork 10
Switch to pnpm 10 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: abernier <[email protected]>
Co-authored-by: abernier <[email protected]>
|
@copilot can we avoid the shamefully-hoist at all ? |
Co-authored-by: abernier <[email protected]>
Yes! Removed Fixed missing dependencies in 22 demos:
153 out of 154 demos now build successfully with strict pnpm dependency resolution. (Commit: b394acf) |
|
@copilot > The .npmrc now only has link-workspace-packages=true |
|
@copilot The .npmrc now only has link-workspace-packages=true 👈🏻 why this? can we get rid completely of .npmrc ? |
|
@copilot ci fails, see logs |
Remove explicit version from pnpm/action-setup@v4 to use packageManager field from package.json Co-authored-by: abernier <[email protected]>
Co-authored-by: abernier <[email protected]>
Fixed! The issue was that the CI workflow specified |
|
@copilot ci fails when building, see logs |
Added missing dependencies exposed by pnpm's strict resolution: - @react-spring/core, @react-spring/web to floating-laptop, wobbling-sphere - @pmndrs/branding to progressive-loading-states-with-suspense, re-using-geometry-and-level-of-detail - three-mesh-bvh to bvh - three-stdlib to 12 demos (baking-soft-shadows, bloom-hdr-workflow-gltf, color-grading, diamond-refraction, diamond-ring, gltf-animations-re-used, html-input-fields, instanced-particles-effects, inter-epoxy-resin, mount-transitions, object-clump, viking-ship, moksha, nextjs-prism) - postprocessing to 5 demos (building-dynamic-envmaps, glass-flower, nextjs-prism, starwars, zustand-site) - @dimforge/rapier3d-compat to minecraft - zustand to audio-analyser, racing-game - glslify, glsl-noise to threejs-journey-portal (and upgraded vite-plugin-glslify to 2.3.0) - lodash to shopping - use-asset to moksha - Fixed react-merge-refs import in infinite-scroll (changed to named import) All 154 demos now build successfully with pnpm's strict dependency resolution. Co-authored-by: abernier <[email protected]>
Fixed! All missing dependencies have been added to satisfy pnpm's strict dependency resolution. All 154 demos now build successfully with Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot test using https://github.com/nektos/act |
Tested using act (nektos/act v0.2.83). The full workflow couldn't complete due to GitHub Pages authentication requirements in the However, I directly tested the critical command
The pnpm migration with Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Tasks: 1 successful, 1 total |
Co-authored-by: abernier <[email protected]>
|
@copilot but previously the "run build" script was correctly building all the demos + the website |
Co-authored-by: abernier <[email protected]>
|
@copilot final test with act ! |
Tested with act successfully! The pnpm migration is working correctly: ✅ Verified The website build fails locally due to network restrictions (can't fetch Google Fonts from The migration is complete and ready for CI testing! Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: abernier <[email protected]>
Migrates package manager from npm to pnpm 10 (latest version 10.26.2) with clean configuration.
Changes
[email protected]withpnpm>=10engine requirementpackage-lock.jsonwithpnpm-lock.yamlpnpm-workspace.yamlfor workspace declarationspnpm/action-setup@v4(auto-detects version from packageManager field)corepack enable && pnpm install --frozen-lockfileConfiguration
No
.npmrcfile needed - uses pnpm's default strict dependency resolution. Thelink-workspace-packagessetting defaults totruewhenpnpm-workspace.yamlis present.Dependency fixes
Fixed 30+ missing dependencies exposed by pnpm's strict resolution across 30 demos:
@react-spring/coreand@react-spring/webto floating-laptop and wobbling-sphereAll dependencies are now properly declared in their respective packages, enabling all 154 demos to build successfully with pnpm's strict dependency resolution.
Testing
act(nektos/act v0.2.83) to verify CI workflowpnpm run ttest --continuecorrectly passes flags to turboOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.