Adds 'spo web alert get' command. Closes #6862 - #7228
Conversation
|
@mvanhorn, please respect our way of working and ask us to assign an issue before working on one. This will prevent two contributors from working on the same issue. |
|
If you've fixed the pipeline issue, you can reopen this PR. |
667956a to
90f23cc
Compare
|
@milanholemans you're right, and I owe you a real apology. @Jwaegebaert flagged the same thing on #7221 two days ago and I said I'd claim issues before working on them. Then I opened this PR without doing that. That's a broken commitment, not a misunderstanding. I've pushed a fix for the failing test (the 'sets telemetry properties' assertion was wrong - getTelemetryProperties skips required options, so it could never return I'm going to pause any new PRs to this repo until I can be sure my workflow actually claims the issue first. If you'd prefer I close this one rather than reopen, I'm happy to do that too - your call. |
|
@milanholemans I guess the related issue was quite old as I would say this command should now be |
|
Since alerts are EOL this month, I think naming it |
Renames the command per the review thread (alerts are EOL this month; the underlying API object is a rule): source, tests, docs, sidebar.
|
Renamed to |
Adam-it
left a comment
There was a problem hiding this comment.
@mvanhorn I forgot to mention that last time, sorry thats on me, but besides uing rule instead of alert it would be best if we would still keep the old naming as an alias
similar like we do in all other spo web rule.. commands
For example
https://pnp.github.io/cli-microsoft365/beta/cmd/spo/web/web-rule-list
in this case we should add an alias for spo web alert get
Matches the convention used by the other renamed spo web rule commands, so existing scripts calling the alert name keep working.
|
No problem, and good call — added in a5b7447.
Still in draft — say the word and I'll mark it ready. |
Closes #6862
Adds the
spo web alert getcommand, which retrieves the details of a specific alert from a SharePoint site list.The command accepts the SharePoint site URL (
-u, --webUrl) and the alert GUID (--id), and callsWeb/Alerts/GetById('<id>')expandingList,User, andList/Rootfolderso the returned payload exposes the list title, root folder path, and user principal name alongside the core alert fields.Follows the existing
spo web alert list/spo web alert removecommand structure: