Open
Conversation
Drakulix
reviewed
Jan 5, 2026
| KeyboardFocusTarget::Fullscreen(s) => Some(s) == fullscreen.map(|f| &f.surface), | ||
| KeyboardFocusTarget::Element(m) => fullscreen | ||
| .is_some_and(|f| m.windows().any(|(s, _)| s == &f.surface)), | ||
| _ => false, |
Member
There was a problem hiding this comment.
This is weird. I'd assume those windows are override-redirect windows otherwise they really shouldn't be Elements but fullscreen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Correctly hide panels for fullscreen Xwayland apps
This PR addresses issue #2840 where COSMIC panels (top and bottom bars) would remain visible when an Xwayland application (such as Proton games) entered fullscreen mode.
The issue was caused by the
has_focused_fullscreencheck insrc/shell/focus/order.rsstrictly checking forKeyboardFocusTarget::Fullscreen. However, Xwayland windows are often focused asKeyboardFocusTarget::Elementeven when they are in fullscreen state.This fix updates the logic to check if the currently focused element corresponds to the active fullscreen surface, regardless of the wrapper variant (
ElementorFullscreen).Closes: pop-os/cosmic-epoch#2840
Verification
cargo checkpasses.