fix: switch outputs at workspace boundaries instead of wrapping#2023
Open
mdurepos wants to merge 2 commits intopop-os:masterfrom
Open
fix: switch outputs at workspace boundaries instead of wrapping#2023mdurepos wants to merge 2 commits intopop-os:masterfrom
mdurepos wants to merge 2 commits intopop-os:masterfrom
Conversation
Previously, when navigating past the first or last workspace using directional keys (e.g., Up/Down with vertical workspace layout), workspaces would wrap around (last→first or first→last). This prevented users from switching to adjacent outputs in that direction. This change: - At workspace boundaries, first check if there's an output to switch to in that direction - If an output exists, switch to it (previous behavior was broken) - If no output exists, wrap workspaces as before This restores the expected behavior where pressing Up on the first workspace switches to the output above (if one exists), and pressing Down on the last workspace switches to the output below. Fixes navigation between vertically-arranged monitors when using vertical workspace layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when navigating past the first or last workspace using directional keys (e.g., Up/Down with vertical workspace layout), workspaces would wrap around (last→first or first→last). This prevented users from switching to adjacent outputs in that direction.
This change:
This restores the expected behavior where pressing Up on the first workspace switches to the output above (if one exists), and pressing Down on the last workspace switches to the output below.
Fixes navigation between vertically-arranged monitors when using vertical workspace layout.