Skip to content

Comments

Implement input method support to COSMIC specific text widgets#1103

Draft
kenz-gelsoft wants to merge 4 commits intopop-os:masterfrom
kenz-gelsoft:backport-input-method2
Draft

Implement input method support to COSMIC specific text widgets#1103
kenz-gelsoft wants to merge 4 commits intopop-os:masterfrom
kenz-gelsoft:backport-input-method2

Conversation

@kenz-gelsoft
Copy link

@kenz-gelsoft kenz-gelsoft commented Jan 24, 2026

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

This is a FYI PR for future reference after the COSMIC team rebased the libcosmic to iced 14.0.

The input method support in iced 14.0 requires text widgets to implement some logic to support input method input. This PR includes this for the COSMIC specific text widgets.

This PR depends on my pop-os/iced fork. Please see PRs I opened:


Changes in this PR

Opt-in the IME feature of the toolkit when text widgets have focus

  • specifies the position of the IME candidates window from the caret location or the selection region.

Handles optional IME events in text widgets

  • to show the composing text (a.k.a. preedit) by passing through it to the toolkit.
  • to commit the composing text by reusing the clipboard paste logic.

(I will force-push this branch to update my fork to rebase to newer upstream rev)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant