Skip to content

Comments

feat(text_input): add select_range method and Task function#1135

Open
Dellareti wants to merge 1 commit intopop-os:masterfrom
Dellareti:feat/select-range
Open

feat(text_input): add select_range method and Task function#1135
Dellareti wants to merge 1 commit intopop-os:masterfrom
Dellareti:feat/select-range

Conversation

@Dellareti
Copy link

Adds a public select_range(start, end) method to text_input::State and a corresponding Task function, following the same pattern as select_all.

Depends on: Dellareti/iced#1 (adds select_range to the iced TextInput operation trait)

Note: The iced submodule reference will need to be updated once the iced PR is merged.

Related: pop-os/cosmic-files#181

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@Dellareti
Copy link
Author

Adds a public select_range(start, end) method to text_input::State and a corresponding Task function, following the same pattern as select_all

Depends on: pop-os/iced#260 (adds select_range to the iced TextInput operation trait)

Note: The iced submodule reference will need to be updated once the iced PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant