Conversation
14233c2 to
8313739
Compare
|
Tested this on KDE, Windows, and MacOS with the cosmic app template (did have to update the iced submodule) and so far it seems to work pretty well. The only thing I would add (more because of this bug on MacOS really) is that moving the window using the cosmic header bar should probably be disabled when using SSD. |
|
Also, on MacOS, the cursor doesn't change for the window controls for some reason, but that probably should be looked at separately. |
|
@pyroraptor07 thanks for testing! I think that the window should still be moveable by the header bar because it means you don't have to aim for a small titlebar - this is how it functions on KDE and it's very useful. I would look at both of those Mac bugs, but I don't have access to one unfortunately. |
That's fair enough, and those bugs should probably be looked at as separate issues anyways. I have access to a mac, but I have very little experience with the macos environment, so I'm not sure how much help I'd be troubleshooting them. But again, not related to this PR. |
This PR adds support for SSD in libcosmic via a config option.
CSD is default on Linux, but will be disabled if the option in the toolkit config file or in
app::settings::Settingsare true.On MacOS and Windows, SSD is default: see the last comment on #523. It will be disabled if the option in the toolkit config file or in
app::settings::Settingsare false.(I know it's not technically SSD on Mac and Windows but it functions mostly the same)
Fixes: