Skip to content

Comments

Account for full document renders#5028

Open
JoviDeCroock wants to merge 3 commits intov10.xfrom
account-for-full-document-render
Open

Account for full document renders#5028
JoviDeCroock wants to merge 3 commits intov10.xfrom
account-for-full-document-render

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Feb 19, 2026

If we see document as the hydration root we actually need to zoom out as the user will want to render the full document so html which is the firstChild and the childNodes of documentElement needs to be included

@JoviDeCroock
Account for full document renders
414f9e4 
If we see `document` as the hydration root we actually need to zoom out as the user will want to render the full document so `html` which is the firstChild and the childNodes of documentElement needs to be included
@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-1.22ms - +6.76ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.04ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.87ms - +1.25ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.05ms - +0.05ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.42ms - +1.50ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.11ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +2% (-0.04ms - +0.68ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +1% (-1.44ms - +0.24ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +4% (-0.31ms - +0.25ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +3% (-0.03ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local887.67ms - 893.43ms-unsure 🔍
-0% - +1%
-1.22ms - +6.76ms
preact-main885.02ms - 890.54msunsure 🔍
-1% - +0%
-6.76ms - +1.22ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.20ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main19.19ms - 19.19msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.52ms - 16.56ms-unsure 🔍
-0% - +0%
-0.04ms - +0.02ms
preact-main16.52ms - 16.56msunsure 🔍
-0% - +0%
-0.02ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.56ms - 1.56ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main1.56ms - 1.56msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local60.64ms - 62.12ms-unsure 🔍
-1% - +2%
-0.87ms - +1.25ms
preact-main60.43ms - 61.94msunsure 🔍
-2% - +1%
-1.25ms - +0.87ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.77ms - 7.16ms-unsure 🔍
-4% - +4%
-0.31ms - +0.25ms
preact-main6.80ms - 7.20msunsure 🔍
-4% - +4%
-0.25ms - +0.31ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.49ms - 16.56ms-unsure 🔍
-0% - +0%
-0.05ms - +0.05ms
preact-main16.49ms - 16.56msunsure 🔍
-0% - +0%
-0.05ms - +0.05ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-main3.71ms - 3.72msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5389

  • Commit: 7007064

duration

VersionAvg timevs preact-localvs preact-main
preact-local62.62ms - 64.05ms-unsure 🔍
-1% - +2%
-0.42ms - +1.50ms
preact-main62.15ms - 63.44msunsure 🔍
-2% - +1%
-1.50ms - +0.42ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.01ms - 3.01ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main3.01ms - 3.01msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.30ms - 29.39ms-unsure 🔍
-2% - +3%
-0.69ms - +0.76ms
preact-main28.34ms - 29.28msunsure 🔍
-3% - +2%
-0.76ms - +0.69ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local34.61ms - 36.05ms-unsure 🔍
-1% - +5%
-0.28ms - +1.74ms
preact-main33.88ms - 35.31msunsure 🔍
-5% - +1%
-1.74ms - +0.28ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local34.63ms - 35.87ms-unsure 🔍
-4% - +1%
-1.42ms - +0.43ms
preact-main35.06ms - 36.43msunsure 🔍
-1% - +4%
-0.43ms - +1.42ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.79ms - 28.51ms-unsure 🔍
-1% - +2%
-0.26ms - +0.67ms
preact-main27.66ms - 28.24msunsure 🔍
-2% - +1%
-0.67ms - +0.26ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local24.94ms - 26.25ms-unsure 🔍
-4% - +3%
-1.03ms - +0.84ms
preact-main25.03ms - 26.36msunsure 🔍
-3% - +4%
-0.84ms - +1.03ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.89ms - 23.53ms-unsure 🔍
-1% - +3%
-0.12ms - +0.67ms
preact-main22.70ms - 23.16msunsure 🔍
-3% - +0%
-0.67ms - +0.12ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #5389

  • Commit: 7007064

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.06ms - 2.17ms-unsure 🔍
-5% - +4%
-0.11ms - +0.08ms
preact-main2.05ms - 2.21msunsure 🔍
-4% - +5%
-0.08ms - +0.11ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.00ms - 1.04ms-unsure 🔍
-3% - +3%
-0.03ms - +0.03ms
preact-main0.99ms - 1.03msunsure 🔍
-3% - +2%
-0.03ms - +0.03ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.42ms - 34.05ms-unsure 🔍
-0% - +2%
-0.04ms - +0.68ms
preact-main33.25ms - 33.58msunsure 🔍
-2% - +0%
-0.68ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.24ms - 1.25msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k
  • Browser: chrome-headless
  • Sample size: 140
  • Built by: CI #5389

  • Commit: 7007064

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.98ms - 31.14ms-unsure 🔍
-5% - +1%
-1.44ms - +0.24ms
preact-main30.56ms - 31.76msunsure 🔍
-1% - +5%
-0.24ms - +1.44ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 2.98ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.97ms - 2.98msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

Size Change: +51 B (+0.06%)

Total Size: 78.8 kB

Filename Size Change
dist/preact.js 4.72 kB +8 B (+0.17%)
dist/preact.min.js 4.73 kB +7 B (+0.15%)
dist/preact.min.module.js 4.75 kB +7 B (+0.15%)
dist/preact.min.umd.js 4.76 kB +7 B (+0.15%)
dist/preact.mjs 4.74 kB +8 B (+0.17%)
dist/preact.module.js 4.74 kB +8 B (+0.17%)
dist/preact.umd.js 4.76 kB +6 B (+0.13%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.18 kB
compat/dist/compat.mjs 4.11 kB
compat/dist/compat.module.js 4.11 kB
compat/dist/compat.umd.js 4.25 kB
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.module.js 3.85 kB
debug/dist/debug.umd.js 3.93 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.mjs 1.56 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.59 kB
jsx-runtime/dist/jsxRuntime.js 1.01 kB
jsx-runtime/dist/jsxRuntime.mjs 985 B
jsx-runtime/dist/jsxRuntime.module.js 985 B
jsx-runtime/dist/jsxRuntime.umd.js 1.08 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock force-pushed the account-for-full-document-render branch from 2f06a12 to 7007064 Compare February 19, 2026 17:54
This was referenced Feb 19, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JoviDeCroock