Build the full release flavor without Firebase - #61
Merged
Conversation
The v0.6.0 release build failed in processFullReleaseGoogleServices: the full flavor appends the .full applicationId suffix (introduced with the product flavors in 0.6.0), and the google-services.json provisioned from the GOOGLE_SERVICES_BASE64 secret has no client registered for se.premex.mcp.full. The full flavor targets F-Droid and direct distribution where Google services are not permitted, so the correct behaviour is to build it without Firebase entirely. Firebase remains enabled for the Play flavor builds. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.6.0 release build failed in
:app:processFullReleaseGoogleServiceswithNo matching client found for package name 'se.premex.mcp.full'. The product flavors introduced in 0.6.0 give the full flavor a.fullapplicationId suffix, and thegoogle-services.jsonprovisioned from theGOOGLE_SERVICES_BASE64secret only contains a client forse.premex.mcp.The full flavor targets F-Droid and direct distribution, where Google services are not permitted. This change builds the full release without
-PenableFirebase=true, matching the intent of the distribution split. Firebase remains enabled for the Play flavor build and publish steps.Alternative considered
Registering
se.premex.mcp.fullas an additional Android app in the Firebase project and updating the secret would also unblock the build, but would ship Firebase in the F-Droid/direct-distribution artifact, which conflicts with F-Droid inclusion policy.Testing
assembleFullReleasewithout the Firebase property matches how the full flavor builds in PR CI today (thepr.ymlworkflow never passes-PenableFirebase).🤖 Generated with Claude Code