Skip to content

Fix: Preserve acronym casing (ID, URL, API, JSON, ...) issue!#39

Open
romeosarkar10x wants to merge 2 commits intoprivatenumber:masterfrom
romeosarkar10x:master
Open

Fix: Preserve acronym casing (ID, URL, API, JSON, ...) issue!#39
romeosarkar10x wants to merge 2 commits intoprivatenumber:masterfrom
romeosarkar10x:master

Conversation

@romeosarkar10x
Copy link

Updated the code to support preserving acronym casing.

@privatenumber
Copy link
Owner

The types will need to be updated too

@romeosarkar10x
Copy link
Author

The types will need to be updated too

Yeah sure, I could work on that too.
You mean this repo: https://github.com/privatenumber/type-flag.git

@privatenumber
Copy link
Owner

I opened a PR here: privatenumber/type-flag#42
Turns out no type changes were necessary

@romeosarkar10x
Copy link
Author

I opened a PR here: privatenumber/type-flag#42 Turns out no type changes were necessary

Thanks, I got a little busy. Didn't get time to review it.
So we can merge this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants