Add support for dataset cloning#71
Open
MHumm wants to merge 1 commit intoproject-jedi:masterfrom
MHumm:feature/add_CloneDataset_support_to_JvMemoryDataset
Open
Add support for dataset cloning#71MHumm wants to merge 1 commit intoproject-jedi:masterfrom MHumm:feature/add_CloneDataset_support_to_JvMemoryDataset
MHumm wants to merge 1 commit intoproject-jedi:masterfrom
MHumm:feature/add_CloneDataset_support_to_JvMemoryDataset
Conversation
obones
requested changes
Apr 30, 2019
Member
obones
left a comment
obones
left a comment
There was a problem hiding this comment.
To me, this is needlessly complexified by the use of a manually allocated record and I won't merge it as is
| TJvMemDataCloneOptions = set of TJvMemDataCloneOption; | ||
|
|
||
| PJvMemDataCommon = ^TJvMemDataCommon; | ||
| TJvMemDataCommon = record |
Member
There was a problem hiding this comment.
I'm sorry, but I don't see the point of this record, and it gets even worse with its allocation being done manually via a getmem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the commits of "Couple of small enhancements to JvMemoryDataset and XPButton" pull request #55 extracted as single commit. I hope it is good enough in this form to be pulled.