fix(images): force per-product refresh on every build#726
Merged
castrojo merged 1 commit intoprojectbluefin:mainfrom Apr 6, 2026
Merged
fix(images): force per-product refresh on every build#726castrojo merged 1 commit intoprojectbluefin:mainfrom
castrojo merged 1 commit intoprojectbluefin:mainfrom
Conversation
IMAGES_CACHE_HOURS: "0" bypasses the outer file-age check in fetch-github-images.js, but the inner per-product shouldRefresh check uses REFRESH_HOURS (default 336h). When actions/cache restores images.json, its mtime is "now" (~0h old), so shouldRefresh evaluates to false and cached product data is returned without re-fetching nvidia tags from GHCR. The nvidia beta tag (bluefin-nvidia-open:beta) was published 2026-04-03 but every build since has returned the stale cache entry with nvidiaCommand: null because per-product data was never re-fetched. Setting IMAGES_REFRESH_HOURS: "0" ensures ageHours (≈0) >= 0 is always true, so every product is re-fetched on every build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMAGES_CACHE_HOURS: "0" bypasses the outer file-age check in fetch-github-images.js, but the inner per-product shouldRefresh check uses REFRESH_HOURS (default 336h). When actions/cache restores images.json, its mtime is "now" (~0h old), so shouldRefresh evaluates to false and cached product data is returned without re-fetching nvidia tags from GHCR.
The nvidia beta tag (bluefin-nvidia-open:beta) was published 2026-04-03 but every build since has returned the stale cache entry with nvidiaCommand: null because per-product data was never re-fetched.
Setting IMAGES_REFRESH_HOURS: "0" ensures ageHours (≈0) >= 0 is always true, so every product is re-fetched on every build.