fix(core): report contentDOM replacement mutations - #263
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@prosemirror-adapter/core
@prosemirror-adapter/lit
@prosemirror-adapter/preact
@prosemirror-adapter/react
@prosemirror-adapter/solid
@prosemirror-adapter/svelte
@prosemirror-adapter/vue
commit: |
ocavue
marked this pull request as ready for review
July 24, 2026 18:17
ocavue
marked this pull request as draft
July 24, 2026 18:22
ocavue
marked this pull request as ready for review
July 24, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
contentDOM.contentDOMis restored, so ProseMirror can preserve the first typed character.@prosemirror-adapter/core.Why
After the browser removes
contentDOM, the adapter reports that removal but ignores the following replacement mutations because their targets are no longer inside the detachedcontentDOM. ProseMirror therefore never sees the newly typed content.This change keeps reporting mutations inside the node view until
contentDOMis restored. It fixes the regression for Preact, React, Solid, Svelte, and Vue. Lit still exposes an upstreamprosemirror-viewcontent-element recovery problem.Validation
pnpm fixpnpm typecheckpnpm lintpnpm build