Import cleanup#101
Open
Cabalist wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neat project! We are waiting to receive our MK3 and I have been poking around in the different Prusa3D projects.
I removed all the
import *, and organized the imports according to PEP8. The code functionally should be identical but it is much easier to see what is being used.I was on the fence about the long imports I made from
OpenGL.GL. These blocks could be replaced by just importing theGLnamespace and prepending the calls in the code. i.efrom OpenGL import GL; GL.glEnableThe only place I changed code besides the imports was in
sceneRender.pywherefrom PIL.Image import *was overwriting the buildingopenfunction. I changed it to beImage.open()instead.(This includes my earlier pull request that removes the
.idea/directory. )