Fix transfer status permission checks#5573
Merged
DaneEveritt merged 10 commits intopterodactyl:1.0-developfrom Mar 26, 2026
Merged
Fix transfer status permission checks#5573DaneEveritt merged 10 commits intopterodactyl:1.0-developfrom
DaneEveritt merged 10 commits intopterodactyl:1.0-developfrom
Conversation
checked if servers node was the new node before updating the server, always failing. Now the requesting node is checked if it's the new node
Contributor
Author
|
Noticed that there was also an issue with the failed transfer status update node checks. Checked against the servers current node instead of the requesting node. So the check always passed when the servers current node was check against the old node in the transfer, since it wouldn't have been updated due to the failed transfer. |
MrSoulPenguin
changed the title
didn't replace duplicate node model creation in createServerModel to reduce scope of changes
Contributor
Author
|
Went ahead and added some test cases to cover this in the future, and fixed a typo I didn't notice before. |
|
bump, same issues |
Contributor
Author
If you're saying you've experienced the same issue this pr addresses, then it's probably best to do so on the linked issue. Doing it on the pr seems like you're stating that you're still experiencing the issue after testing the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the new node was checked against the servers current node (the old node) before the server is updated to the new node, causing the check to always fail.
Now the requesting node is checked against the new node.
Resolves #5572