util/shmctl: refine command-line UI: SHMinit = init, reworded [options]#132
Open
IepIweidieng wants to merge 2 commits intoptt:masterfrom
Open
util/shmctl: refine command-line UI: SHMinit = init, reworded [options]#132IepIweidieng wants to merge 2 commits intoptt:masterfrom
IepIweidieng wants to merge 2 commits intoptt:masterfrom
Conversation
* fix <invalid-command> failing without `uhash_loader` first
by postponing SHM operations until necessary
* main()
* make "SHMinit" & "init" treated the same
so that SHMinit no longer requires uhash_loader
but no longer resolve_garbage() (pttcache) & resolve_fcache()
* add previously implicit command "init" into cmd[]
* rearrange codes into an early return pattern
* main()
IepIweidieng
force-pushed
the
feat-refine-shmctl-ui
branch
from
89d9ccd to
59661c2
Compare
IepIweidieng
changed the title
chhsiao1981
reviewed
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shmctl SHMinitnow no longer invokesresolve_garbage()(for pttcache) &resolve_fcache().shmctl SHMinitis now identical toshmctl initand no longer requiresuhash_loaderto execute beforehand.uhash_loaderto execute, soshmctl -hnow always works.shmctlcommand have been made more clarified.shmctl inithas now been included.See the commit messages for details.