dev: enable the react compiler (and upgrade next)#1284
Draft
Conversation
tefkah
requested review from
3mcd and
allisonking
and removed request for
allisonking
tefkah
commented
Jun 3, 2025
Member
Author
There was a problem hiding this comment.
need to enable eslint to catch things that would break the react-compiler in context-editor
tefkah
commented
Jun 3, 2025
Comment on lines
36
to
-40
| export const LinkMenu = ({ mark, onChange }: LinkMenuProps) => { | ||
| if (!(mark.type.name === "link")) { | ||
| return null; | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
can't early return if you use hooks
tefkah
commented
Jun 3, 2025
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
High-level Explanation of PR
Enables the react compiler!
Also adds a way to detect excessive refreshes through
react-scanThis can be disabled by turning it off in the bottom right, or by setting
REACT_SCAN_ENABLED=falseincore/.env.localTest Plan
Best way to test is to locally
pnpm -F core dev/compiler-demo(this page will be removed when this is merged).next.config.ts. setexperimental.reactCompiler: false.I also did the same in
storybook, bc that requires specific configuration.ill add a video tomorrow
Screenshots (if applicable)
Notes