Merged
Conversation
Recently, a customer brought up that our docker and hocon dependencies are a little out of date and they were receiving warnings about it. We do still use both of these modules, so this upgrades their version dependencies to help.
This module is based on a very old version of the pdk. This uses pdk update with pdk 3.6.1 to modernize it
Contributor
|
Think you could easily add a GH Action that runs specs on PR? For some reason I thought that might be part of the PDK template, but I guess not. |
eputnam
force-pushed
the
CDPE-7363/upgrade-dependencies
branch
from
826b795 to
95d663a
Compare
Contributor
Author
|
dropped addition of spec tests github action. they're technically out of scope for these changes and we want to deliver customer value asap. |
Magisus
approved these changes
Mar 4, 2026
The PDK update from a previous commit was a little too aggressive and got rid of some things we need to run spec tests on this module. Re-adding those things along with some other changes, this change restores our ability to run the spec tests on this repo. For the future, when we want to run these spec tests in a github action, we'll need to set up credentials to clone test fixtures that are now all in private repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(CDPE-7363) Upgrade docker and hocon module deps
Recently, a customer brought up that our docker and hocon dependencies are a little out of date and they were receiving warnings about it. We do still use both of these modules, so this upgrades their version dependencies to help.
(CDPE-7363) Modernize with pdk 3.6.1
This module is based on a very old version of the pdk. This uses pdk update with pdk 3.6.1 to modernize it