Document node group configuration migration to puppet-enterprise-modules#643
Draft
Document node group configuration migration to puppet-enterprise-modules#643
Conversation
…terprise-modules Co-authored-by: skay-perf <237744184+skay-perf@users.noreply.github.com>
Co-authored-by: skay-perf <237744184+skay-perf@users.noreply.github.com>
Co-authored-by: skay-perf <237744184+skay-perf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move node groups configuration to puppet enterprise modules
Document node group configuration migration to puppet-enterprise-modules
Jan 14, 2026
bastelfreak
reviewed
Jan 15, 2026
| # @summary Used during the peadm::convert plan | ||
| # | ||
| # TODO: This class should be moved to puppet-enterprise-modules | ||
| # See: https://github.com/puppetlabs/puppet-enterprise-modules/tree/main/modules |
Collaborator
There was a problem hiding this comment.
There is a puppet-strings tag that you can use, @see
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node group configuration is PE infrastructure concern, not PEADM orchestration. This PR marks all node group management code for migration to puppet-enterprise-modules with TODO comments and comprehensive documentation.
Files marked for migration:
manifests/setup/node_manager.pp- Creates PE infrastructure node groups (Primary A/B, Compiler Groups, Database, etc.)manifests/setup/node_manager_yaml.pp- Bolt apply configuration helpermanifests/setup/legacy_compiler_group.pp- Legacy compiler node groupsmanifests/setup/convert_node_manager.pp- PEADM 2.x→3.x migration helperUsage points annotated:
plans/subplans/configure.pp- Initial installplans/upgrade.pp- PE upgradesplans/convert.pp- Installation conversionsplans/convert_compiler_to_legacy.pp- Compiler conversionsplans/util/update_classification.pp- Classification updatesDocumentation added:
documentation/node_group_migration.md- Migration plan, current state, target architectureAll changes are documentation/comments only. No functional code modified. See https://github.com/puppetlabs/puppet-enterprise-modules/tree/main/modules
Additional Context
Node group configuration manages PE's own infrastructure classification - belongs with PE modules, not deployment tooling. Current implementation works but creates coupling between PEADM and PE internals. Migration enables PE team to maintain PE-specific configuration directly.
Related Issues (if any)
N/A
Checklist
Changes include test coverage?
Have you updated the documentation?
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.