Fix nil provider crash when purging unconfigured EC2 resources#700
Open
Fix nil provider crash when purging unconfigured EC2 resources#700
Conversation
Add nil guard in purge_vms_and_resources: when a provider is listed in config but not initialized in $providers, log and return early instead of crashing with: undefined method provider_config for nil:NilClass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a provider (e.g., EC2) is listed under
:providersin config but is not initialized in$providers(missing credentials, not fully configured, etc.),purge_vms_and_resourcescrashes with:This error was observed in production logs on startup when
purge_unconfigured_resourcesruns for the EC2 provider.Fix
Add a nil guard in
purge_vms_and_resources: if$providers[provider_name]is nil, log and return early instead of raisingNoMethodError.Testing
:providerswithout initializing it in$providers; before this fix it crashes, after this fix it logs and skips cleanly