Skip to content

Add initial support for protocol mode B#21

Open
emontnemery wants to merge 2 commits intopwitab:masterfrom
emontnemery:mode_b_support
Open

Add initial support for protocol mode B#21
emontnemery wants to merge 2 commits intopwitab:masterfrom
emontnemery:mode_b_support

Conversation

@emontnemery
Copy link
Copy Markdown

This adds basic support for mode B:

  • Add baudrate map for mode B
  • Skip mode selection for standard readout

Accessing of programming mode is not implemented

@Krolken
Copy link
Copy Markdown
Contributor

Krolken commented Aug 18, 2021

Thanks for starting support for Mode B.

But I would prefer a separate Client object over a mode selection arg.

So to have
ModeCClient and ModeBClient

I think that would keep the code more maintainable and fixes for one type of meter would give less risk of breaking stuff for others.

Once A, D and E mode are implemented the code would othewise be filled with tons of if-statements making it hard to understand.

@emontnemery
Copy link
Copy Markdown
Author

OK, that sounds good!
Just to confirm, you mean refactoring by splitting out the specifics for each mode to subclasses of Iec6205621Client, which will then be an abstract class?

@Krolken
Copy link
Copy Markdown
Contributor

Krolken commented Aug 18, 2021

I started a discussion about it for better collaboration. #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants