Add initial support for protocol mode B#21
Open
emontnemery wants to merge 2 commits intopwitab:masterfrom
Open
Add initial support for protocol mode B#21emontnemery wants to merge 2 commits intopwitab:masterfrom
emontnemery wants to merge 2 commits intopwitab:masterfrom
Conversation
Contributor
|
Thanks for starting support for Mode B. But I would prefer a separate Client object over a mode selection arg. So to have I think that would keep the code more maintainable and fixes for one type of meter would give less risk of breaking stuff for others. Once A, D and E mode are implemented the code would othewise be filled with tons of if-statements making it hard to understand. |
Author
|
OK, that sounds good! |
Contributor
|
I started a discussion about it for better collaboration. #22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic support for mode B:
Accessing of programming mode is not implemented