Conversation
Teew35
approved these changes
Dec 23, 2024
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
src/rust/cryptography-x509/src/pkcs7.rs:14
- [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub struct ContentInfo<'a, Op: Asn1Operation> {
src/rust/cryptography-x509/src/pkcs7.rs:22
- [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub enum Content<'a, Op: Asn1Operation> {
src/rust/cryptography-x509/src/pkcs7.rs:34
- [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub struct SignedData<'a, Op: Asn1Operation> {
src/rust/cryptography-x509/src/pkcs7.rs:64
- [nitpick] The type parameter name 'Op' is ambiguous. It should be renamed to 'Asn1Op' for better clarity.
pub struct EnvelopedData<'a, Op: Asn1Operation> {
This does not currently work because rust-asn1 doesn't handle Asn1Definedby{Readable,Writable} correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not currently work because rust-asn1 doesn't handle Asn1Definedby{Readable,Writable} correctly