asn1: Add support for SIZE to remaining types
#13990
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facutuesca
changed the title
SIZE to missing typesSIZE to remaining types
Signed-off-by: Facundo Tuesca <[email protected]>
Signed-off-by: Facundo Tuesca <[email protected]>
Signed-off-by: Facundo Tuesca <[email protected]>
facutuesca
force-pushed
the
ft/asn1-size-all
branch
from
9a5f114 to
9d2d4b9
Compare
Member
|
Sorry, can we please do this one type at a time? The size of this PR makes it difficult to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #13899, this PR extends the support for SIZE annotations to the remaining supported types:
UTF8String,OCTET STRING,BIT STRING,PrintableStringandIA5String.The actual change is pretty small, most of the lines changed in this PR are for new tests.
Part of #12283