[ref:seggan/feature/elektrikity] ELEKTRIKITY by Seggan · Pull Request #971 · pylonmc/pylon

Seggan · 2026-05-05T18:10:47Z

See #987 section "Foundational Pylon PR"

# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonBlocks.java # src/main/resources/lang/en.yml

# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonBlocks.java # src/main/java/io/github/pylonmc/pylon/PylonFluids.java # src/main/java/io/github/pylonmc/pylon/PylonItems.java # src/main/java/io/github/pylonmc/pylon/PylonKeys.java # src/main/java/io/github/pylonmc/pylon/content/components/FluidHatch.java # src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryBurner.java # src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryController.java # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml # src/main/resources/researches.yml

…ektrikity

# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonItems.java # src/main/java/io/github/pylonmc/pylon/PylonRecipes.java # src/main/java/io/github/pylonmc/pylon/content/components/FluidHatch.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselBreaker.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselBrickMolder.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselFurnace.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselGrindstone.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselPipeBender.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselPress.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselQuarry.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselTableSaw.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/PalladiumCondenser.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/production/Biorefinery.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/production/Fermenter.java # src/main/java/io/github/pylonmc/pylon/content/machines/experience/FluidExperienceBottler.java # src/main/java/io/github/pylonmc/pylon/content/machines/fluid/FluidLimiter.java # src/main/java/io/github/pylonmc/pylon/content/machines/hydraulics/Quarry.java # src/main/java/io/github/pylonmc/pylon/content/machines/smelting/Bloomery.java # src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryBurner.java # src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryController.java # src/main/resources/lang/en.yml

JustAHuman-xD · 2026-06-06T02:59:53Z

+    @lombok.Builder.Default
+    private final Consumer<Player> reopenWindow = _unused -> {};


this is unused completely? also no idea why you would need to re-open the window, also is there a reason this is in pylon and not rebar?

It was used to reopen the window once the player had inputted a specific value in the chat, now that that's been removed this currently sits unused while we switch it over to dialogs

+1 to moving this to Rebar

JustAHuman-xD · 2026-06-06T03:02:50Z

-            .material(material)
+            .itemStack(
+                    ItemStackBuilder.of(material)
+                    .addCustomModelDataString("pylon:display_projectile/" + key)


Suggested change

.addCustomModelDataString("pylon:display_projectile/" + key)

.addCustomModelDataString("pylon:display_projectile:" + key)

JustAHuman-xD · 2026-06-06T03:03:11Z

+
+    private static final ItemStackBuilder NOT_BURNING = ItemStackBuilder.of(Material.CHARCOAL)
+            .name(Component.translatable("pylon.gui.burning.not_burning"))
+            .addCustomModelDataString("pylon:burner_progress/not_burning");


Suggested change

.addCustomModelDataString("pylon:burner_progress/not_burning");

.addCustomModelDataString("pylon:burner_progress:not_burning");

JustAHuman-xD · 2026-06-06T03:03:19Z

+            .addCustomModelDataString("pylon:burner_progress/not_burning");
+    private static final ItemStackBuilder BURNING = ItemStackBuilder.of(Material.BLAZE_POWDER)
+            .name(Component.translatable("pylon.gui.burning.burning"))
+            .addCustomModelDataString("pylon:burner_progress/burning");


Suggested change

.addCustomModelDataString("pylon:burner_progress/burning");

.addCustomModelDataString("pylon:burner_progress:burning");

JustAHuman-xD · 2026-06-06T03:05:17Z

        Furnace furnace = (Furnace) getBlock().getBlockData();
        furnace.setLit(false);
        getBlock().setBlockData(furnace);
+        refreshBlockTextureItem();


Suggested change

refreshBlockTextureItem();

the block texture entities now automatically update when block data changes so you don't need to manually refresh it

Should probably be documented somewhere

JustAHuman-xD · 2026-06-06T03:08:07Z

+
+
+
+
+


JustAHuman-xD · 2026-06-06T03:14:09Z

+    protected abstract @NotNull List<ItemStack> getResults(@NotNull T recipe);
+
+    protected boolean tryStartRecipe(T recipe, ItemStack stack) {
+        RecipeInput.Item input = (RecipeInput.Item) recipe.getInputs().getFirst();
+        if (!input.matches(stack)) {
+            return false;
+        }
+
+        List<ItemStack> results = getResults(recipe);
+        if (results.size() > 3) {
+            throw new IllegalStateException("Recipe has more than 3 results, which is not supported by GenericMachine");
+        }
+
+        if (!outputInventory.canHold(results)) {
+            return true;
+        }
+
+        this.results = results;
+        startRecipe(recipe, getRecipeTicks(recipe));
+        getRecipeProgressItem().setItem(ItemStackBuilder.of(stack.asOne()).clearLore());
+        inputInventory.setItem(new MachineUpdateReason(), 0, stack.subtract(input.getAmount()));
+        return true;
+    }


I would update getResults & how you use it so that you clone the return value of getResults instead of all the implementations supplying clones

reduce the tons of .clone() in implementing classes

you can clone only when you are sure those are going to be the results which can save memory & tick time

JustAHuman-xD · 2026-06-06T03:15:25Z

+        if (max != null) {
+            lore.add(Component.translatable("pylon.gui.number-button.max", RebarArgument.of("max", valueFormatter.apply(max))));
+        }
+        return ItemStackBuilder.gui(material, pylonKey("number_input_button"))


I would say we'd want custom model data specific to each usage of this not a singular "number_input_button"

JustAHuman-xD · 2026-06-06T03:17:53Z

+        Location playerLocation = event.getPlayer().getLocation();
+        ElectricityPylon pylon = BlockStorage.getByType(ElectricityPylon.class).stream()
+                .min(Comparator.comparing(p -> p.getBlock().getLocation().toCenterLocation().distanceSquared(playerLocation)))
+                .filter(p -> p.getBlock().getLocation().toCenterLocation().distanceSquared(playerLocation) < 64 * 64)
+                .orElse(null);
+        if (pylon == null) return;
+        throw new UnsupportedOperationException("Multimeter interaction not implemented yet");


regardless of how this is changed I just don't think we should every be using getByType like this, instead maybe getting by chunk in a chunk radius loop if you don't change this to just be direct block interaction (which is what I think this should be)

even if you do keep using getByType like this, this will throw an exception for any blocks not in the same dimension as the player, but again I would not do this.

Oh oops forgot to remove debug code lol

LordIdra

Stuff I have found from in-game testing so far (have not looked at code much yet):

Almost everything is missing recipes

Almost everything is missing researches

Basically all electric machines are missing WAILAs. (Might be worth rebasing off my PR for this since you'll have to change the WAILAs anyway? I am happy to rebase it and deal with conflicts if you want)

Quarries appear to now be trying to mine air? Not 100% sure if that was introduced by this PR

A lot of the electric machines are iron blocks. I would use some more variety here as it makes them very hard to distinguish, as we do for diesel and hydraulic machines. You could do this in conjunction with some very simple item displays potentially, if you want to keep the base as an iron blocks.

It is also a bit strange that some electric machines have extra item displays (like the press) and some don't

Would be worth adding electric experience bottler (I know this requires a rework of the experience bottler... this is why we should not abstract stuff like we did with the bottler...)

I am not able to test several items in this PR because they immediately cause errors...

LordIdra · 2026-06-08T15:53:15Z

    public static final SimpleStaticGuidePage CARGO = new SimpleStaticGuidePage(pylonKey("machines_cargo"));
    public static final SimpleStaticGuidePage DIESEL_MACHINES = new SimpleStaticGuidePage(pylonKey("machines_diesel_machines"));
    public static final SimpleStaticGuidePage DIESEL_PRODUCTION = new SimpleStaticGuidePage(pylonKey("machines_diesel_production"));
+    public static final SimpleStaticGuidePage ELECTRICITY = new SimpleStaticGuidePage(pylonKey("machines_electricity"));


Maybe split this into Electricity Production, Electric Machines, and Electric Utilities?

LordIdra · 2026-06-08T16:02:52Z

+    @Override
+    public void tick() {
+        ElectricNetwork network = getElectricNodes().getFirst().getNetwork();
+        for (ElectricNode node : network.getNodes()) {
+            Particle.DUST.builder()
+                    .color(Color.fromARGB(network.hashCode()))
+                    .location(node.getBlock().toLocation().toCenterLocation().add(0, 0.6, 0))
+                    .receivers(32, true)
+                    .spawn();
+        }
+    }


Forgot to remove?

LordIdra · 2026-06-08T16:04:46Z

This being a sea lantern feels a bit weird, and the name is also a bit weird considering it's much more a node than a pylon from a player perspective. Maybe worth changing this to use a small cube item display and changing it to 'Electric connector' or similar?

LordIdra · 2026-06-08T16:07:47Z

+    public static final ItemStack WIRE_1_GAUGE = ItemStackBuilder.rebar(Material.STRING, PylonKeys.WIRE_1_GAUGE)
+            .build();
+
+    static {
+        RebarItem.register(PylonWire.class, WIRE_1_GAUGE, PylonKeys.WIRE_1_GAUGE);
+        PylonPages.TOOLS.addItem(WIRE_1_GAUGE);
+    }


This being in tools doesn't make much sense from a gameplay perspective - I'd suggest moving it to electric machines or components

LordIdra · 2026-06-08T16:10:37Z

Would it be possible to use six item displays which each span the length of the block, rather than twelve? I know this is quite annoying, but given how many of these are likely to be placed I'm very worried about performance

LordIdra · 2026-06-08T16:25:11Z

+  heat_exchanger:
+    name: "Heat Exchanger"
+    lore: |-
+      <arrow> Exchanges heat between two fluids


Clueless on what this does from the description

LordIdra · 2026-06-08T16:27:49Z

The WAILA just constantly errors when not completed

LordIdra · 2026-06-08T16:29:28Z

The turbine errors and turns into a phantom block on completion???

LordIdra · 2026-06-08T16:36:03Z

+  wire_1_gauge:
+    name: "1-Gauge Wire"
+    lore: |-
+      <arrow> Transmits electricity
+      <arrow> <attr>Max power:</attr> %max-power%


Missing instructions

LordIdra · 2026-06-08T16:52:39Z

Might be worth having the power connection on the top or back here

Seggan · 2026-06-08T17:46:15Z

I mentioned in Discord that I'm splitting the electric content PR into 2: these are just the base, and recipes/researches/more items will come in my next PR

LordIdra · 2026-06-08T16:55:08Z

Why aren't we using FluidTankWithDisplayEntity here?

Cause the original code didn't

The original code worked differently so it didn't need to. The way it works now I think you can take advantage of FluidTankWithDisplayEntity to remove a lot of code

LordIdra · 2026-06-08T17:48:15Z

+    name: "Gas Turbine"
+    lore: |-
+      <arrow> Uses hot gases to produce power
+      <arrow> The more hot gases piped into it, the more power it produces


Ah ok. SO presumably it'll be fine once the display recipes are viewable. Might still be worth adding something to hint towards that like 'different gases produce different amounts of power' but idk

# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonRecipes.java # src/main/java/io/github/pylonmc/pylon/content/components/FluidHatch.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselBrickMolder.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselFurnace.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselGrindstone.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselPipeBender.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselPress.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/DieselTableSaw.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/machines/PalladiumCondenser.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/production/Biorefinery.java # src/main/java/io/github/pylonmc/pylon/content/machines/diesel/production/Fermenter.java # src/main/java/io/github/pylonmc/pylon/content/machines/hydraulics/BurnerHydraulicPurifier.java # src/main/java/io/github/pylonmc/pylon/content/machines/hydraulics/Quarry.java # src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryBurner.java # src/main/java/io/github/pylonmc/pylon/guide/HydraulicRefuelableItemsPage.java # src/main/resources/lang/en.yml

Seggan added 30 commits March 11, 2026 13:17

Add Electricity Pylon

ede6425

Add base code

bd61dec

Simple networks

9fb3fb8

Add creative power source and generify number input

ab607f6

Allow electricity pylon to connect to any electricity block

45e9dc7

Don't need this no more

c256663

Move the listeners to listener class

883769d

Skeleton electric grindstone

4defe36

Merge branch 'master' into seggan/feature/elektrikity

a6c171f

Slightly broken but ok

83a6597

Add projectile key (closes #562)

933fa7a

Merge branch 'master' into seggan/feature/elektrikity

0279c55

# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonBlocks.java # src/main/resources/lang/en.yml

Start multimeter

bfed3d6

Rewrite node API

e2d993b

Start transformer

fa20743

Rewrite connections

6e0ec78

Add transformers

6535b3d

Take wires

1cd3a5b

Working capacitors/acceptors

0277dc0

Boiler

69402e2

Boiler recipe

852ac2e

Steam power go brr

22a20b7

Basic gas turbine multiblock

e43dc98

Electricity input/output hatches

da19c36

Rewrite fluid hatches

4b7823b

Nuke voltage

d7720bf

Fix multiblock facing

a1fc803

Multiblock gas turbine (spinny!!!!)

9e6d929

Recipe pages

b862925

Particles

76b5515

Seggan and others added 5 commits June 1, 2026 10:20

Fix compilation

38fd615

Generify machines

9c0fb4a

Merge branch 'human/listener-interface-update' into seggan/feature/el…

c1e9d46

…ektrikity

fixes

8e21bec

AlmostPanda reviewed Jun 1, 2026

View reviewed changes

Comment thread src/main/resources/lang/en.yml Outdated

JustAHuman-xD and others added 6 commits June 1, 2026 12:43

fixes

c37d115

Add electric compressor

40c11b5

Make it clearer

fa0e369

Fix compile

a0dd366

Add electric mixer

78693e5

Seggan marked this pull request as ready for review June 3, 2026 17:33

*21

61d64eb

JustAHuman-xD reviewed Jun 6, 2026

View reviewed changes

LordIdra requested changes Jun 8, 2026

View reviewed changes

LordIdra reviewed Jun 8, 2026

View reviewed changes

Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/electricity/generation/Boiler.java Outdated

Seggan added 11 commits June 16, 2026 21:46

Fix compile

49d1b84

Nuuk boiler

b55b214

Nuuk multimeter

ac1c13a

Nuuk Vectors.kt

dba48c3

Refactor nodes

817803a

Nuuk pdc param

c0760ef

s/amount/millibuckets

11f0e7d

Merge branch 'master' into seggan/feature/elektrikity

083f42e

s/reopenWindow/open

ad466ec

Set capacitor priority to max

7bedd83

		@lombok.Builder.Default
		private final Consumer<Player> reopenWindow = _unused -> {};

	.addCustomModelDataString("pylon:display_projectile/" + key)
	.addCustomModelDataString("pylon:display_projectile:" + key)

	.addCustomModelDataString("pylon:burner_progress/not_burning");
	.addCustomModelDataString("pylon:burner_progress:not_burning");

Uh oh!

Conversation

Seggan commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LordIdra left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Seggan commented Jun 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Seggan commented May 5, 2026 •

edited

Loading