Improve string representation of Advanced(Inc)Subtensor#1931
Open
AdishreeB wants to merge 1 commit intopymc-devs:v3from
Open
Improve string representation of Advanced(Inc)Subtensor#1931AdishreeB wants to merge 1 commit intopymc-devs:v3from
AdishreeB wants to merge 1 commit intopymc-devs:v3from
Conversation
ricardoV94
approved these changes
Mar 4, 2026
ricardoV94
changed the title
Move str_from_slice, str_from_indices, and __str__ to BaseSubtensor so that Subtensor, AdvancedSubtensor, and other subclasses inherit a consistent string representation. Only IncSubtensor and AdvancedIncSubtensor override __str__ for custom naming. Closes pymc-devs#1906 Co-authored-by: Adishree <jellybeing315@gmail.com> Co-authored-by: Aman Srivastava <amansri345@gmail.com>
ricardoV94
force-pushed
the
enh-advanced-subtensor-repr
branch
from
a6118a9 to
a765e8d
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves str_from_slice and str_from_indices from Subtensor to BaseSubtensor and adds a shared str method. AdvancedIncSubtensor and IncSubtensor now use super() to call these methods. AdvancedSubtensor inherits str directly from BaseSubtensor.
Related Issue
Checklist
Type of change