Skip to content

Reup spec000 [2026-04-25]#753

Merged
martinfleis merged 8 commits intopysal:mainfrom
jGaboardi:reup_spec000_2026_04_16
Apr 27, 2026
Merged

Reup spec000 [2026-04-25]#753
martinfleis merged 8 commits intopysal:mainfrom
jGaboardi:reup_spec000_2026_04_16

Conversation

@jGaboardi
Copy link
Copy Markdown
Member

@jGaboardi jGaboardi commented Apr 25, 2026

@jGaboardi jGaboardi self-assigned this Apr 25, 2026
@jGaboardi jGaboardi added admin/maint dependencies Pull requests that update a dependency file labels Apr 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.3%. Comparing base (4037c70) to head (7e2db3a).
⚠️ Report is 154 commits behind head on main.

Files with missing lines Patch % Lines
momepy/elements.py 80.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #753     +/-   ##
=======================================
+ Coverage   97.4%   98.3%   +0.9%     
=======================================
  Files         26      28      +2     
  Lines       4328    4505    +177     
=======================================
+ Hits        4214    4428    +214     
+ Misses       114      77     -37     
Files with missing lines Coverage Δ
momepy/tests/test_elements.py 100.0% <100.0%> (ø)
momepy/elements.py 98.5% <80.0%> (+1.6%) ⬆️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread momepy/elements.py
@jGaboardi
Copy link
Copy Markdown
Member Author

re: 312-oldest failure

In [1]: import shapely

In [2]: shapely.geos_version
Out[2]: (3, 14, 1)
geometry = 0    POLYGON ((30.415 30, 29.923 30, 29.431 30, 28....
1    POLYGON ((15.646 30, 16.138 30, 16.631 30, 17....
2    POLYGON ((49.64 94.055, 49.32 93.582, 49.011 9...
3    GEOMETRYCOLLECTION (POLYGON ((15.646 90, 16.13...
4    POLYGON ((30.989 63.109, 30.68 63.582, 30.36 6...
5    POLYGON ((47.123 39.704, 46.631 40.112, 46.138...
6    POLYGON ((15.646 64.851, 16.138 64.989, 16.631...
7    POLYGON ((64.354 77.326, 63.862 76.964, 63.369...

@martinfleis
Copy link
Copy Markdown
Member

I have no idea given the geos and shapely in the oldest is the same as in the latest.

@martinfleis
Copy link
Copy Markdown
Member

I have wrapped the simplification in try/except as it can be brittle. The remaining issue in oldest is of unknown origin... I'd just skip the geometry type check.

Comment thread momepy/tests/test_elements.py Outdated
Comment thread momepy/tests/test_elements.py
@martinfleis martinfleis merged commit 461c6be into pysal:main Apr 27, 2026
15 checks passed
@jGaboardi jGaboardi deleted the reup_spec000_2026_04_16 branch April 27, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admin/maint dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simplify by default in *_tessellation()

2 participants