Skip to content

fix: validate SA3 extraction mode early #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samay2504 wants to merge 1 commit into from
+3 −2
Closed

fix: validate SA3 extraction mode early #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions spopt/region/sa3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ def extract_clusters(linkage_matrix, min_cluster_size, extraction="eom"):

"""

if extraction not in ("eom", "leaf"):
raise ValueError("Unsupported extraction method. Use one of ('eom', 'leaf').")

n_samples = linkage_matrix.shape[0] + 1

try:
Expand All @@ -57,8 +60,6 @@ def extract_clusters(linkage_matrix, min_cluster_size, extraction="eom"):
)
elif extraction == "leaf":
selected_clusters = extract_leaves(condensed_tree, allow_single_cluster=False)
else:
raise ValueError("Unsupported extraction method. Use one of ('eom', 'leaf').")

return get_cluster_label_vector(condensed_tree, selected_clusters, 0, n_samples)

Expand Down
Loading