Drop support for PySide2 - #583
Conversation
The-Compiler
left a comment
There was a problem hiding this comment.
Seems fine other than the tests I commented on. Personally I'd still keep it for another ~2 years (Python 3.10 EOL -> not possible to run anymore on any supported Python) given that it's not really in the way. But I'm also fine with getting rid of it, given that Qt 6.0 is 4 years old already, and 6.2 (first release with e.g. QtWebEngine available) has been around for more than 3 years. Time flies!
| pass | ||
| assert blocker.all_signals_and_args == [] | ||
|
|
||
| def test_empty_when_no_signal_name_available(self, qtbot, signaller): |
There was a problem hiding this comment.
I'm a bit confused by the current situation here (also for the test below) - is this really only relevant for PySide2, or did we just never add PySide6 to the test?
From what this looks like:
pytest-qt/src/pytestqt/wait_signal.py
Lines 104 to 123 in 89178ed
and from [PYSIDE-1911] Provide a way to get the name of a Signal(Instance) - Qt Bug Tracker only being partially fixed (I think we never implemented the "extract from repr" part?), I believe those tests should still be run on PySide6 actually?
There was a problem hiding this comment.
Ahh great catch! You are right, they should be running for PySide 6 too.
Brought the tests back and updated the condition.
c6e55d6 to
7ac3f70
Compare
PySide2 is no longer maintained, with the last release being made in 2022.
7ac3f70 to
e00b4cd
Compare
PySide2 is no longer maintained, with the last release being made in 2022.
Follow-up to #572 (comment).
@The-Compiler I like the removed cruft and CI jobs, but I understand if you would like to keep the support around.