gh-143421: Use new buffer to save optimized uops #143682
Conversation
cocolato
requested review from
Fidget-Spinner,
markshannon and
tomasr8
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
@Fidget-Spinner There may be many details that need fixing, and I hope you can give me some suggestions. |
|
I haven't yet removed the cases of cpython/Python/optimizer_analysis.c Line 244 in 03e6457 |
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Thanks, this is really valuable work. We definitely need this.
Python/optimizer_analysis.c
Outdated
| int last_opcode = ctx->out_buffer[ctx->out_len - 1].opcode; | ||
| if (last_opcode != _EXIT_TRACE && | ||
| last_opcode != _JUMP_TO_TOP && | ||
| last_opcode != _DYNAMIC_EXIT && | ||
| last_opcode != _DEOPT) { | ||
| return 0; |
There was a problem hiding this comment.
Please use is_terminator.
Also, instead of return 0, you should insert an _EXIT_TRACE there pointing to the current target.
|
|
||
| op(_GUARD_TOS_INT, (value -- value)) { | ||
| if (sym_is_compact_int(value)) { | ||
| REPLACE_OP(this_instr, _NOP, 0, 0); |
There was a problem hiding this comment.
All these REPLACE_OP should be left untouched. As you already have a mechanism to copy over the current op if there's no ADD_OP called right :) ?
| bool insert_mode) | ||
| { | ||
| if (sym_matches_type(value, &PyBool_Type)) { | ||
| REPLACE_OP(this_instr, _NOP, 0, 0); |
There was a problem hiding this comment.
All these REPLACE_OP should be left untouched as well. They should stay the same.
|
Thanks for taking the time to review this! I will rewrite them later. |
3 participants
Uh oh!
There was an error while loading. Please reload this page.