Add xplat cxx_binary target for bench_transposed_cache benchmark#18718
Open
kimishpatel wants to merge 1 commit intogh/kimishpatel/238/basefrom
Open
Add xplat cxx_binary target for bench_transposed_cache benchmark#18718kimishpatel wants to merge 1 commit intogh/kimishpatel/238/basefrom
kimishpatel wants to merge 1 commit intogh/kimishpatel/238/basefrom
Conversation
The fbcode cpp_benchmark target forces macOS x86_64 compatibility, making it unusable on arm64 Macs. Add a non_fbcode_target cxx_binary so the benchmark can be built and run locally via: buck build fbsource//xplat/executorch/extension/llm/custom_ops:bench_transposed_cache Also wrap the existing fbcode cpp_benchmark in fbcode_target() to avoid duplicate target name conflicts. Authored with Claude. Differential Revision: [D99677682](https://our.internmc.facebook.com/intern/diff/D99677682/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18718
Note: Links to docs will display an error until the docs builds have been completed. ❌ 126 New FailuresAs of commit e05dcc6 with merge base fb1618e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 6, 2026
Open
This PR needs a
|
meta-cla
bot
added
the
CLA Signed
Contributor
Author
|
submitted by accident, not meant to land immedidately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The fbcode cpp_benchmark target forces macOS x86_64 compatibility,
making it unusable on arm64 Macs. Add a non_fbcode_target cxx_binary
so the benchmark can be built and run locally via:
buck build fbsource//xplat/executorch/extension/llm/custom_ops:bench_transposed_cache
Also wrap the existing fbcode cpp_benchmark in fbcode_target() to
avoid duplicate target name conflicts.
Authored with Claude.
Differential Revision: D99677682