Skip to content

Qualcomm AI Engine Direct - Add claude skill for qualcomm#18831

Open
shewu-quic wants to merge 3 commits intopytorch:mainfrom
CodeLinaro:dev1/hutton/add_claude_skill_for_qualcomm
Open

Qualcomm AI Engine Direct - Add claude skill for qualcomm#18831
shewu-quic wants to merge 3 commits intopytorch:mainfrom
CodeLinaro:dev1/hutton/add_claude_skill_for_qualcomm

Conversation

@shewu-quic
Copy link
Copy Markdown
Collaborator

@shewu-quic shewu-quic commented Apr 13, 2026

Summary:

  • Add essential functionality in qualcomm skill, such as build, test, and add new op
    • /qualcomm build with /path/to/qairt/2.42.0.251225/
    • /qualcomm test test_qnn_backend_channel_shuffle in fp and quantized
  • Use qualcomm skill to develop new op "ChannelShuffle" and add test case

@shewu-quic
Qualcomm AI Engine Direct - Add claude skill for qualcomm
94d970b 
Summary:
- Add essential functionality in qualcomm skill, such as build, test, and add new op
  - /qualcomm build with /path/to/qairt/2.42.0.251225/
  - /qualcomm test test_qnn_backend_channel_shuffle in fp and quantized
- Use qualcomm skill to develop new op "ChannelShuffle" and add test case
@shewu-quic
Updated CLAUDE.md
701a459
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 13, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18831

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 2 Unrelated Failures

As of commit bc46b34 with merge base 411ede2 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shewu-quic
Copy link
Copy Markdown
Collaborator Author

shewu-quic commented Apr 13, 2026

Hi @abhinaykukkadapu,

This PR introduces some initial Claude skills for Qualcomm. The debugger skill and custom op skill will be included in future PRs.
Could you please help to take a look?

Thanks,
Hutton

abhinaykukkadapu
abhinaykukkadapu approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@abhinaykukkadapu abhinaykukkadapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shewu-quic this is awesome, thanks for adding the claude skill support.

.claude/skills/qualcomm/SKILL.md
| Export / lowering / quantization options / pass pipelines | `lowering_export.md` | User asks about exporting, lowering, quantization config, QuantDtype, QuantRecipe, pass pipelines |
| New op development | `new_op_development.md` | User asks to add/implement a new op or op builder |
| Model enablement | `model_enablement.md` | User asks to enable a new model end-to-end |
| Profiling & debugging | `profiling.md` | User asks about profiling, optrace, QHAS, QAIRT Visualizer *(file TBD)* |
Copy link
Copy Markdown
Contributor

@abhinaykukkadapu abhinaykukkadapu Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

profiling.md is not available in this PR?

.claude/skills/qualcomm/SKILL.md
Comment on lines +25 to +26
- `QNN_SDK_ROOT` — path to QNN SDK (auto-downloaded if not set)
- `ANDROID_NDK_ROOT` — path to Android NDK (auto-downloaded if not set)
Copy link
Copy Markdown
Contributor

@abhinaykukkadapu abhinaykukkadapu Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add PYTHON_PATH and LD_LIBRARY_PATH?

.claude/skills/qualcomm/new_op_development.md
@@ -0,0 +1,361 @@
# New Op Development

Full reference: `backends/qualcomm/builders/README.md` (op builder) and `backends/qualcomm/quantizer/README.md` (quantizer annotation).
Copy link
Copy Markdown
Contributor

@abhinaykukkadapu abhinaykukkadapu Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can have a skill for custom ops via op package as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinaykukkadapu abhinaykukkadapu abhinaykukkadapu approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shewu-quic @abhinaykukkadapu