[CRCR] Implement on-call bot and allowlist functionality for downstream CI failures#8183
Draft
KarhouTam wants to merge 1 commit into
Draft
[CRCR] Implement on-call bot and allowlist functionality for downstream CI failures#8183KarhouTam wants to merge 1 commit into
KarhouTam wants to merge 1 commit into
Conversation
|
@KarhouTam is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement CRCR on-call bot and merge-blocking logic for downstream CI failures, driven by a structured allowlist (L1-L4) that maps downstream repos to severity levels and on-call contacts.
Changes
CRCR Allowlist (
lib/crcrAllowlist.ts)Parses
.github/allowlist.ymlfrompytorch/pytorch, mapping downstream repos to four levels:Includes a 15-minute in-memory cache and strict YAML validation. Errors fail open.
On-call Bot (
lib/bot/crcrOncallBot.ts)A Probot bot on
check_run.completed: when a CRCR check run fails, looks up on-calls from the allowlist and posts a tagged comment on the associated PR. Deduplicates via an HTML comment marker.Merge Blocking (
lib/bot/pytorchBotHandler.ts)@pytorchbot mergechecks the GitHub Checks API for CRCR failures on the PR head commit. L4 failures block the merge with a comment listing failing repos.-fbypasses this, consistent with existing force-merge semantics. Errors fail open.Dr.CI Integration
fetchRecentWorkflows.ts: NewfetchOotWorkflows()queriesoot_workflow_jobfrom ClickHouse.drci.ts: L4 failures appear as blocking; L3 failures appear in a new "OUT OF TREE (non-blocking)" section.Tests
Unit tests for allowlist parsing and on-call bot behavior, plus updated Dr.CI test helpers.