Check that images referenced in the docs really exist at their place#10904
Merged
Conversation
DelazJ
added
the
backport release_3.44
3 tasks
Member
|
I'm struggling to review the changes here, GitHub just times out when I click the changed files tab. I'll check on my local machine... |
Member
|
LGTM - we can come back to the gif checks later. |
…vel folder instead of docs
and adjust substitutions accordingly
instead of substitutions
and adjust substitutions accordingly
…ker happier Also remove situations where file does not exist
and adjust the checker script to temporarily ignore image files with '*' as extension value. Files can be .gif, .png or anything else so some more cases to cover... later.
DelazJ
force-pushed
the
check_image_refs
branch
from
b194b19 to
432eac8
Compare
DelazJ
added a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subset of #10856
This one is a bit... well. Quite a journey.
The script doesn't consider whether the image referenced is actually used or not (e.g. if mentioned in a commented out text or in a code-sample area. Images MUST exist. Anyway I adjusted the docs to fit in.
Still remains one point requiring a more skilled developer: handling images that are referenced with
*extension, because they exist as gif (for HTML build) and png (for PDF build). I simply skip their checking for now.@timlinux ?