Add ARM target for PDP Cortex-m7 bringup - #167
Open
nnadgaud wants to merge 1 commit into
Open
Conversation
Previously the "arm" entry in LIBQEMU_TARGETS was silently remapped to "aarch64" in CMakeLists.txt, so a 32-bit ARM target could never be built on its own. Remove the remap and: - Build libqemu/wrappers/target/arm.c for TARGET_ARM in addition to TARGET_AARCH64. - Widen the ARM-specific exports in libqemu/exports.py (cp15_cbar, NVIC link, exclusive-access, post-init, register-reset) from arch='aarch64' to arch='aarch64|arm' so they are also available under TARGET_ARM. Signed-off-by: Nikhita Nadgauda <nnadgaud@qti.qualcomm.com>
Brian Cain (androm3da)
requested review from
Pierrick Bouvier (p-b-o) and
Philippe Mathieu-Daudé (philmd)
August 20, 2026 15:05
Brian Cain (androm3da)
approved these changes
Aug 20, 2026
Brian Cain (androm3da)
left a comment
Brian Cain (androm3da)
left a comment
Member
There was a problem hiding this comment.
QEMU generally refers to the 32-bit target as arm, so removing the remap is a good idea. This change makes sense to me.
But let's hear what Phil and Pierrick think.
|
The change in itself looks fine. In QEMU, aarch64 target is capable of running anything arm target can. There are even discussions to drop qemu-*-arm completely upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the "arm" entry in LIBQEMU_TARGETS was silently remapped to "aarch64" in CMakeLists.txt, so a 32-bit ARM target could never be built on its own. Remove the remap and: