Switch from sassc to sass-embedded (Dart Sass) for faster builds#2669
Closed
rolfedh wants to merge 1 commit into
Closed
Switch from sassc to sass-embedded (Dart Sass) for faster builds#2669rolfedh wants to merge 1 commit into
rolfedh wants to merge 1 commit into
Conversation
Bump jekyll-sass-converter to ~> 3.0, which replaced sassc (LibSass) with sass-embedded (Dart Sass) in v3.0.0. Dart Sass ships prebuilt platform binaries, so bundle install no longer compiles a native C++ extension (the main install/CI bottleneck). Jekyll is already 4.4.1, which permits jekyll-sass-converter < 4.0, so no Jekyll bump is needed. - Gemfile: jekyll-sass-converter ~> 2.0 -> ~> 3.0 - Gemfile.lock: drop sassc, add sass-embedded; add x86_64-linux platform (sass-embedded is platform-specific; CI runs on ubuntu-latest) - Rename _sass/includes/brand.css -> brand.scss: it uses Sass variables, which LibSass tolerated in imported .css but Dart Sass rejects as plain CSS - blog.scss: darken() -> color.adjust() (deprecated global color function) Fixes quarkusio#2551
|
🙈 The PR is closed and the preview is expired. |
Contributor
Author
|
Closing as superseded by the Roq migration (#2683). The site is moving off Jekyll to Roq, so swapping sassc for sass-embedded on the soon-to-be-retired Jekyll build is no longer worth pursuing. Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump jekyll-sass-converter to ~> 3.0, which replaced sassc (LibSass) with sass-embedded (Dart Sass) in v3.0.0. Dart Sass ships prebuilt platform binaries, so bundle install no longer compiles a native C++ extension (the main install/CI bottleneck). Jekyll is already 4.4.1, which permits jekyll-sass-converter < 4.0, so no Jekyll bump is needed.
Fixes #2551
** If you are updating a guide, please submit your pull request to the main repository: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc **