Test/fragment anchor validation#2713
Draft
holly-cummins wants to merge 2 commits into
Draft
Conversation
Compare the built site against the gh-pages branch to find changed HTML files. When 15 or fewer pages changed and no build infrastructure files were modified, run the link crawler only on those pages (depth-1 check). This avoids a full-site crawl on small PRs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Crawls internal pages and verifies that #fragment targets exist as element IDs on the destination page. Uses the same test.crawl.* properties as LinkCrawlerTest so both tests share the same Maven command line, including incremental mode from changed-paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking as draft, because this is red! Which is good!
I mean, it's bad that it's red, but it's found problems that need fixing before it can merge. This tests #anchor in pages, rather than just the top level page. Bad anchors won't cause a 404, but they're sloppy – and easy to get wrong. (I'm surprised our adoc doesn't pick them, is there a strictness setting we need to be changing?)