Remove $baseurl template preprocessing from SCSS#2744
Merged
Conversation
…mages consistently use baseurl
The $baseurl variable was injected into SCSS via Jekyll Liquid preprocessing — a pattern that doesn't transfer to other static site generators. Since quarkus.io assets are always served from the domain root, the variable was always empty and the concatenation was a no-op. Use plain absolute paths instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
🙈 The PR is closed and the preview is expired. |
Contributor
Author
|
I've worked through the URLs which use background images, like https://quarkus-website-pr-2744-preview.surge.sh/events/, and all seem fine. |
gsmet
approved these changes
Jun 22, 2026
github-project-automation
Bot
moved this from Todo
to Done
in WG - Convert quarkus.io to Roq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the first things where I've been unable to come up with a roq alternative for something done in Jekyll. Jekyll uses template processing to inject a value into a stylesheet, and then uses that injected value in a variable used elsewhere in css. The value is $baseurl, a path prefix. It would be useful if quarkus.io was hosted in a sub-path of another site, like commhaus.org/quarkus. But we don't have that requirement, and are unlikely to do so, so I think we can reduce complexity by just ditching the $baseurl.
If we don't want to do that, the other option is to use a maven step or a
sedin a CI step to edit the css and put in the blank path prefix for $baseurl, but that seems like a lot of complexity for very little gain.This PR:
$baseurlSCSS variable that was injected via Jekyll Liquid preprocessing ($baseurl: "{{ site.baseurl }}")url($baseurl + '/assets/...')with plainurl('/assets/...')across 8 SCSS filesBuilds on #2740, so should be reviewed and merged after that one. .
We need check these pages on the preview to verify background images render correctly:
/) — hero section background image (bg-home-primary.png)/guides/) — category icons (tutorials, how-to, concepts, reference, PDF) in both light and dark mode/guides/getting-started) — guide type icons in the breadcrumb area/version/main/guides/) — same category icons + quarkiverse icon on quarkiverse extensionsbg-footer.png), visible on wide screens (≥1024px)/spring/) — title background image/events/) — speaker callout card background