Extend guides tests to check for main as well as the default version#2777
Merged
Conversation
holly-cummins
marked this pull request as draft
June 23, 2026 12:21
holly-cummins
force-pushed
the
extend-guides-tests
branch
3 times, most recently
from
June 23, 2026 13:20
4e768f6 to
e1b24e5
Compare
…oke test The CI build only includes latest and main guide versions, so test those two rather than dynamically reading releases.yaml for LTS versions that aren't present in the CI site. Add tests for specific important guide pages (getting-started, rest, hibernate-orm, cdi, security-overview) to catch deep link regressions. Remove /extensions/ from the smoke test since the extensions page is generated separately. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
holly-cummins
force-pushed
the
extend-guides-tests
branch
from
June 24, 2026 17:05
e1b24e5 to
2cb746e
Compare
holly-cummins
changed the title
holly-cummins
marked this pull request as ready for review
June 24, 2026 17:18
Status for workflow
|
|
🙈 The PR is closed and the preview is expired. |
gsmet
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realised the guides tests check for the latest stable, but not main or some older versions. That would be an easy thing to regress (and we can't even check it in the previews). Sadly, we also can't check anything but main and latest in CI, because the
_only_latest_guides_config.ymlis being used.I had a lovely version of this which avoided hardcoding version strings and used the data in #2750, but it fails in CI because the pages aren't built. So I've scaled down my ambitions and only check main.