Add support for environment variables in rewrite#281
Merged
queer merged 2 commits intoqueer:mistressfrom Jan 18, 2026
Merged
Conversation
queer
approved these changes
Jan 18, 2026
Owner
queer
left a comment
There was a problem hiding this comment.
Awesome stuff, thanks! I should really fix the CI configs someday...
Contributor
Author
|
I'm afraid one of them might be my fault, since I installed tempfile the Cargo.lock version was bumped and it looks like the Actions runner uses an older version that doesn't support that. |
Owner
|
It's not on you; I've not had the energy to update them for a long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280. Please be aware I used Antigravity editor (Gemini-based) to generate the code and some tests, and made slight tweaks to the output.
This PR adds support for environment variables in the rewrite parameter of a rule, for example to specify
$XDG_CACHE_HOMEand similar XDG variables in the rewrite path. It also adds tests tomod.rsfor standard/tilde paths and environment variables requiring expansion. It preserves tildes to maintain the same behavior as before by usingshellexpand::env, which only expands environment variables on evaluation, instead ofshellexpand::full.The newly added tests all pass:
And I have been able to run it successfully on my NixOS system using this
home-managerconfiguration: