Skip to content

Backport #384: Always re-resolve SocketAddress on reconnect #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrjohn merged 2 commits into from
Feb 24, 2026
Merged

Backport #384: Always re-resolve SocketAddress on reconnect #1142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7261a5e
Always re-resolve Socket Address on reconnect. Drops QFJ-822 and rev…
jimbogithub Apr 20, 2021
b218b96
Merge branch 'QFJ_2_3_x' into backport-384-dns-re-resolve
chrjohn Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions quickfixj-core/src/main/java/quickfix/mina/initiator/IoSessionInitiator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ private void pollConnectFuture() {
private void handleConnectException(Throwable e) {
++connectionFailureCount;
SocketAddress socketAddress = socketAddresses[getCurrentSocketAddressIndex()];
unresolveCurrentSocketAddress(socketAddress);
while (e.getCause() != null) {
e = e.getCause();
}
Expand All @@ -284,28 +283,16 @@ private void handleConnectException(Throwable e) {
private SocketAddress getNextSocketAddress() {
SocketAddress socketAddress = socketAddresses[nextSocketAddressIndex];

// QFJ-266 Recreate socket address for unresolved addresses
if (socketAddress instanceof InetSocketAddress) {
InetSocketAddress inetAddr = (InetSocketAddress) socketAddress;
if (inetAddr.isUnresolved()) {
socketAddress = new InetSocketAddress(inetAddr.getHostName(), inetAddr
.getPort());
socketAddresses[nextSocketAddressIndex] = socketAddress;
}
}
// Recreate socket address to avoid cached address resolution
if (socketAddress instanceof InetSocketAddress) {
InetSocketAddress inetAddr = (InetSocketAddress) socketAddress;
socketAddress = new InetSocketAddress(inetAddr.getHostName(), inetAddr.getPort());
socketAddresses[nextSocketAddressIndex] = socketAddress;
}
nextSocketAddressIndex = (nextSocketAddressIndex + 1) % socketAddresses.length;
return socketAddress;
}

// QFJ-822 Reset cached DNS resolution information on connection failure.
private void unresolveCurrentSocketAddress(SocketAddress socketAddress) {
if (socketAddress instanceof InetSocketAddress) {
InetSocketAddress inetAddr = (InetSocketAddress) socketAddress;
socketAddresses[getCurrentSocketAddressIndex()] = InetSocketAddress.createUnresolved(
inetAddr.getHostString(), inetAddr.getPort());
}
}

private int getCurrentSocketAddressIndex() {
return (nextSocketAddressIndex + socketAddresses.length - 1) % socketAddresses.length;
}
Expand Down
Loading