network: support ethernet devices#711
Merged
outfoxxed merged 1 commit intoquickshell-mirror:masterfrom Apr 21, 2026
Merged
Conversation
outfoxxed
force-pushed
the
master
branch
2 times, most recently
from
87bdd97 to
f0d0216
Compare
outfoxxed
requested changes
Apr 8, 2026
Member
outfoxxed
left a comment
outfoxxed
left a comment
There was a problem hiding this comment.
Everything seems to work, didn't spot anything wrong in the impl.
It would be nice if the ethernet/wifi network api had a bit more overlap. The main things I can think of are:
- expose DeviceType on network (makes delegate reuse easier between wifi/wired)
- expose networks[] on all devices, for wired its just always of length 1. Keep the network property though thats better if you know its wired
- keep name on network, just return the device name for ethernet
cpwrs
commented
Apr 9, 2026
cpwrs
commented
Apr 9, 2026
outfoxxed
requested changes
Apr 9, 2026
Member
|
Code looks fine from what I remember, Looks like eths can be renamed on the fly and that happens on my system when I plug devices in. Seeing if its an easy fix edit: yes |
outfoxxed
reviewed
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds EthernetDevice(s) to Networking.devices with properties network, linkSpeed, and hasLink.
Adds NMWiredDevice and NMGenericNetwork to the NM backend. NMGenericNetwork mirrors a base frontend Network for all of the device types that only have one logical network. Backend objects now own the lifetime of their respective frontend object. This gets rid of the need to manage separate lists of frontend objects. NMNetwork is now the common base of NMWirelessNetwork and NMGenericNetwork.