Enhance local build system for faster iteration and better DX#1143
Open
rainux wants to merge 1 commit intoqvacua:masterfrom
Open
Enhance local build system for faster iteration and better DX#1143rainux wants to merge 1 commit intoqvacua:masterfrom
rainux wants to merge 1 commit intoqvacua:masterfrom
Conversation
This commit improves the local development experience by addressing several build system inefficiencies: 1. **Fix Incremental Builds**: Corrected a bug in `bin/build_vimr.sh` where the build directory was always deleted regardless of the `clean` flag. Incremental builds now work as expected. 2. **Optimize Neovim Resources**: `bin/build_nvimserver.sh` now skips downloading/building Neovim resources if they already exist, saving significant time on subsequent builds. 3. **Support Local Signing**: `bin/build_vimr.sh` now performs ad-hoc signing when `notarize=false`, enabling locally built Release versions to run on Apple Silicon without manual codesigning. 4. **Simplify Plugin Validation**: Added `trust_plugins` flag to `bin/build_vimr.sh` to bypass interactive SwiftLint plugin validation prompts. 5. **New Convenience Script**: Added `bin/build_and_install_local_release.sh` to build and install a local Release version to `/Applications` in one step. 6. **Documentation**: Updated `README.md` with instructions for local builds. Co-authored-by: Gemini <gemini@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the local development experience by addressing several build system inefficiencies:
bin/build_vimr.shwhere the build directory was always deleted regardless of thecleanflag. Incremental builds now work as expected.bin/build_nvimserver.shnow skips downloading/building Neovim resources if they already exist, saving significant time on subsequent builds.bin/build_vimr.shnow performs ad-hoc signing whennotarize=false, enabling locally built Release versions to run on Apple Silicon without manual codesigning.trust_pluginsflag tobin/build_vimr.shto bypass interactive SwiftLint plugin validation prompts.bin/build_and_install_local_release.shto build and install a local Release version to/Applicationsin one step.README.mdwith instructions for local builds.Implemented by Gemini.
Since the original code contains mixed indent spaces, I formatted it with 2 spaces indention (which should be the original convention of VimR), so the diff will looks a bit scary, if viewed by ignoring spaces with https://github.com/qvacua/vimr/pull/1143/files?diff=split&w=1, the diff will be very clear.