Update icons, fix parsing for iconoir and Tabler#28
Open
ogdakke wants to merge 1 commit intoqwikest:mainfrom
Open
Update icons, fix parsing for iconoir and Tabler#28ogdakke wants to merge 1 commit intoqwikest:mainfrom
ogdakke wants to merge 1 commit intoqwikest:mainfrom
Conversation
Install qwik-city as a devDependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could not get the dev page or the build working yet, running into errors:
> vite build --mode lib error during build: Error: Missing vite-plugin-qwik-city at configResolved (file:///Users/danielwargh/Documents/Developer/web/icons/node_modules/.pnpm/@builder.io+qwik-city@1.2.14_rollup@3.17.2/node_modules/@builder.io/qwik-city/adapters/static/vite/index.mjs:168:17) at file:///Users/danielwargh/Documents/Developer/web/icons/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.1/node_modules/vite/dist/node/chunks/dep-ca21228b.js:62089:28 at Array.map (<anonymous>) at resolveConfig (file:///Users/danielwargh/Documents/Developer/web/icons/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.1/node_modules/vite/dist/node/chunks/dep-ca21228b.js:62089:14) at async build (file:///Users/danielwargh/Documents/Developer/web/icons/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.1/node_modules/vite/dist/node/chunks/dep-ca21228b.js:44512:20) at async CAC.<anonymous> (file:///Users/danielwargh/Documents/Developer/web/icons/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.1/node_modules/vite/dist/node/cli.js:813:9) ELIFECYCLE Command failed with exit code 1. ``` And when running dev: ``` VITE v4.1.4 ready in 1079 ms ➜ Local: http://localhost:5173/ ➜ Network: use --host to expose ➜ press h to show help ❗️ Expect significant performance loss in development. ❗️ Disabling the browser's cache results in waterfall requests. ctx.load is not a function 3:20:01 PM [vite] Internal server error: ctx.load is not a function Plugin: vite-plugin-qwik File: /Users/danielwargh/Documents/Developer/web/icons/src/page.tsx at Object.transform (file:///Users/danielwargh/Documents/Developer/web/icons/node_modules/.pnpm/@builder.io+qwik@1.2.14_undici@5.20.0/node_modules/@builder.io/qwik/optimizer.mjs:2125:19) at async Object.transform (file:///Users/danielwargh/Documents/Developer/web/icons/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.1/node_modules/vite/dist/node/chunks/dep-ca21228b.js:41685:30) at async loadAndTransform (file:///Users/danielwargh/Documents/Developer/web/icons/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.1/node_modules/vite/dist/node/chunks/dep-ca21228b.js:39479:29)Installed qwik-city as a devDependency, as that seems to be needed for running the build? Let me know if this is incorrect. Would appreciate help getting the build to work, and let me know asap if this PR can ever land here, or should I maintain my own fork.