Fix test when .Library.site has length longer than 1#84
Open
maksymiuks wants to merge 2 commits intor-lib:mainfrom
Open
Fix test when .Library.site has length longer than 1#84maksymiuks wants to merge 2 commits intor-lib:mainfrom
maksymiuks wants to merge 2 commits intor-lib:mainfrom
Conversation
|
Thank you, I independently ran into this same fix, and I will be applying it to fix the Debian package. This PR closes: #83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
When running a testing suit for your package, I discovered that it fails when
.Library.sitehas a length longer than one due to the%in%operator returning a vector of length the same as.Library.site, which cannot be compared using&&operator. I hope addinganyhere fixes it while maintaining test's spirit.