Conversation
Contributor
|
This improves the performance significantly, thanks! One thing though; currently, if the diagram resizes, one does not do the re-calculation, e.g. The dependency is here: qucs_s/qucs/diagrams/graph.cpp Lines 570 to 571 in ad0c643 |
Collaborator
|
Hi MacOS x86_64 build failed. Fix:
// Before (requires Qt 6.6+)
lines.assign(std::begin(joint_lines), std::end(joint_lines));
// After (works with Qt 6.2+)
lines = QList<QLineF>(std::begin(joint_lines), std::end(joint_lines));Fixes macOS CI x86_64 build failure. |
Owner
Author
|
The build for Qt version less than 6.6 and the problem with resize has been fixed. |
Contributor
|
Can confirm the stretching update is now working as expected, thanks! |
Owner
Author
|
Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I have received a patch providing a fix for #1598 by email. This PR reloads graph data only if it was changes.