Update on the "Application Settings->Location" menu UI#1613
Open
andresmmera wants to merge 13 commits intora3xdh:currentfrom
Open
Update on the "Application Settings->Location" menu UI#1613andresmmera wants to merge 13 commits intora3xdh:currentfrom
andresmmera wants to merge 13 commits intora3xdh:currentfrom
Conversation
Added a "Clear All Paths" button to the Locations tab of the settings dialog. This is useful when the user accidentally adds a lot of paths via (e.g. via "Add path with subfolders")
- Add a dialog showing the list of paths to add. - "Select All" and "Deselect All" feature - Only those paths marked to add are actually added
…roupbox This helps to visually identify them
Each path has now a button with a red cross to remove it
Once each path on the list has an individual button for deleting it, it doesn't make sense to have a dedicated button for that on the right side of the panel. Also, the function "slotPathSelectionChanged" is removed as it was only used for toggling the state of the path removal button
The standard path widgets were not grouped. Last commit grouped the widgets related with the search paths, so it makes sense to do the same with the standard paths
This allows the paths to be seen clearly
slotRemovePath is dead code as RemovePathButt was removed
It doesn't need to be a class member
It is not used at all. Indeed it even had a comment saying it's not used. It doesn't make sense to keep it there.
checkStateChanged was introduced in Qt 6.7 [1] and caused a build failure on macOS CI which uses Qt 6.2.4 [2] [1] https://doc.qt.io/qt-6/qcheckbox.html [2] https://github.com/ra3xdh/qucs_s/blob/current/.github/workflows/deploy.yml#L151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It may happen that a user can accidentally add a directory with many subdirectories (e.g. the home dir) via "Add Path With Subfolders". This makes the subcircuit search path list to grow very large.
The only practical way to clear this mesh was to manually edit the configuration file (~/.config/qucs/qucs_s.conf) as the UI only provided the option to remove entries one by one.
This PR adds a button on the UI to clear all the search path entries at once. Once there, I made some more changes I felt convenient.
Changes
Before this PR
After this PR