Simplify dist/iso build flow to bare essentials#25555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dist/packaging scripts minimal and easy to reason about so the essential workflow (build radare2 in a container, produce an ISO, run in QEMU) remains available.Description
dist/iso/Makefileto a minimal set of targets (iso,run,clean,help) and a straightforwarddocker runinvocation that mounts the repo and runs the build script.dist/iso/config.mkto only core variables required to build and run the ISO (image, release, arch, output/work paths, git refs, r2pm and QEMU memory).dist/iso/scripts/build-iso.shto the essential steps: install minimal deps, configurelive-build, add a concise chroot hook that clones and buildsradare2, optionally installsr2pmplugins, and copies the produced ISO intooutput/.dist/iso/README.mdto document the simplified usage and output contract for the reduced interface.Testing
bash -n dist/iso/scripts/build-iso.shwhich completed successfully.makehelp withmake -C dist/iso help, which printed the simplified usage successfully.isotarget withmake -C dist/iso -n iso | head -n 40to confirm the simplified Docker invocation, which showed the expected command and completed without errors.Codex Task