Added Top center corner, refactored position providers to common class#128
Open
Swissman1 wants to merge 2 commits intorafallopatka:master-v2from
Open
Added Top center corner, refactored position providers to common class#128Swissman1 wants to merge 2 commits intorafallopatka:master-v2from
Swissman1 wants to merge 2 commits intorafallopatka:master-v2from
Conversation
Added item to Corner enum, Added cases to each position provider for new item for eject dir and position
Refactored position providers to use a common ancestor, to reuse more code.
|
We are on the same page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option for Top center into the enum, and the position provider cases
Also set them to use a common abstract position provider, which reduces repetition. If too major a change vs just adding top center, I can remove the refactor, let me know